Add unsafe test to check that dropped values are zeroized#1180
Closed
dvdplm wants to merge 2 commits into
Closed
Conversation
tarcieri
reviewed
May 5, 2025
newpavlov
reviewed
May 5, 2025
newpavlov
reviewed
May 5, 2025
Author
|
I guess the original question still stands: is something like this acceptable? I'm on the fence myself, hence the draft. |
Member
|
Personally, while I am fine with having such test, I don't see much worth in it. I will leave the final decision to @tarcieri. As a small suggestion, it may be worth to slightly modify how the test is implemented. Instead of reading leaked memory in the test itself, it may be better to allocate a known size (e.g. 1024 bytes) using |
Member
|
@tarcieri WDYT? I lean towards closing this PR. |
Member
|
While it would be nice to have a test, I worry about including one that has UB |
Member
|
Closing in favor of #1199 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test that zeroization actually occurs when a boxed value goes out of scope.
Uses unsafe code, likely relies on UB and adds a custom allocator, hence the draft: is something like this acceptable?
c.f. iqlusioninc/crates#1310